Ability to search by Time in addition to date

Diskussions related to the development of PhpLogCon

Google Ads


Ability to search by Time in addition to date

Postby sire » Tue Nov 24, 2009 3:06 pm

Hi All,

I have enhanced phpLogCon to be able to search by time interval in addition to date interval.
I have tested it in Opera browser, it works ;)
Patch and screenshot follow.

Regards,
Sergey Sireskin
Attachments
3.PNG
Screenshot
3.PNG (91.01 KiB) Viewed 19094 times
phplogcon-2.7.3-timesearch.patch.gz
Patch
(1.97 KiB) Downloaded 264 times
sire
Avarage
 
Posts: 18
Joined: Thu Nov 12, 2009 1:19 pm

Urgent Question?

  • Pulling out your Hair?
  • Wasting Time and Money?
  • Deadline Approaching?

Re: Ability to search by Time in addition to date

Postby bwinchell » Sun Feb 14, 2010 4:22 am

Will this work with V2.8? Do you have a version for 2.8?
Thanks
bwinchell
Avarage
 
Posts: 12
Joined: Fri Feb 05, 2010 5:39 am

Re: Ability to search by Time in addition to date

Postby sire » Mon Feb 15, 2010 10:39 am

bwinchell wrote:Will this work with V2.8? Do you have a version for 2.8?
Thanks

Didn't notice 2.8 is out. I'll try this later.
sire
Avarage
 
Posts: 18
Joined: Thu Nov 12, 2009 1:19 pm

Re: Ability to search by Time in addition to date

Postby sire » Mon Feb 15, 2010 10:45 am

sire wrote:
bwinchell wrote:Will this work with V2.8? Do you have a version for 2.8?
Thanks

Didn't notice 2.8 is out. I'll try this later.


According to 2.8's changelog there are no much changes from 2.7.3, so this patch should work.
sire
Avarage
 
Posts: 18
Joined: Thu Nov 12, 2009 1:19 pm

Re: Ability to search by Time in addition to date

Postby alorbach » Tue Feb 23, 2010 2:20 pm

Thanks for your contribution, I will integrate this patch into 2.8.1 :)

best regards,
Andre Lorbach
alorbach
Site Admin
 
Posts: 1627
Joined: Thu Feb 13, 2003 11:55 am

Re: Ability to search by Time in addition to date

Postby sire » Fri Feb 26, 2010 12:38 pm

alorbach wrote:Thanks for your contribution, I will integrate this patch into 2.8.1 :)

Excellent!

Regards,
Sergey
sire
Avarage
 
Posts: 18
Joined: Thu Nov 12, 2009 1:19 pm

Re: Ability to search by Time in addition to date

Postby sire » Sat Feb 27, 2010 12:15 pm

alorbach wrote:Thanks for your contribution, I will integrate this patch into 2.8.1 :)

I have found a mistake in my patch in lines 176 and 186 of the patch file .
Code: Select all
>if ( isset($_GET['filter_daterange_to_hour']) ) {
--><------>$filters['filter_daterange_to_hour'] = intval($_GET['filter_daterange_to_hour']);
--><------>if ($filters['filter_daterange_to_hour'] < 10)
--><------>    $filters['filter_daterange_to_hour'] = '0' . $filters['filter_daterange_to_hour'] = 0;
-->}

Code: Select all
>if ( isset($_GET['filter_daterange_to_second']) ) {
--><------>$filters['filter_daterange_to_second'] = intval($_GET['filter_daterange_to_second']);
--><------>if ($filters['filter_daterange_to_second'] < 10)
--><------>    $filters['filter_daterange_to_second'] = '0' . $filters['filter_daterange_to_second'] = 0;
-->}

There should be no
Code: Select all
 = 0
at the end of these lines. I think it appeared there because of my cut and paste programming style :)
sire
Avarage
 
Posts: 18
Joined: Thu Nov 12, 2009 1:19 pm

Re: Ability to search by Time in addition to date

Postby alorbach » Fri Mar 12, 2010 12:30 pm

thanks for the hint, added the fix as well ;)

best regards,
Andre Lorbach
alorbach
Site Admin
 
Posts: 1627
Joined: Thu Feb 13, 2003 11:55 am

Google Ads



Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 0 guests

cron